hl-valdemar/brolang
1
0
Fork 0
Code Issues Pull Requests Actions Packages Releases Wiki Activity

remove undefined global constraint

Browse Source
This commit is contained in:
Valdemar Høgsvig Lorenzen
2026-07-22 02:43:30 +02:00
parent 63f000dd42
commit 0d04925b3a
4 changed files with 29 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files
compiler_tests.odin
+11 -6
View File
@@ -9211,6 +9211,7 @@ counter int = 0
ratio float = 1
span range = 0..2
point Point = Point { x = 1 }
unset Point = undefined
values [_]mut i32 = [10, 20]
main func() void {
counter = 1
@@ -9239,8 +9240,9 @@ main func() void {
found_counter := false
found_ratio := false
found_span := false
found_unset := false
found_values := false
for global in hir_module.globals {
for global, global_index in hir_module.globals {
name := symbol.resolve(&symbols, global.name)
if name == "counter" {
found_counter = global.writable && !global.is_static && types.equal(global.type, types.I32)
@@ -9248,6 +9250,12 @@ main func() void {
found_ratio = global.writable && !global.is_static && types.equal(global.type, types.F64)
} else if name == "span" {
found_span = global.writable && !global.is_static && types.is_range(global.type, &hir_module.types)
} else if name == "unset" {
found_unset = global.writable &&
!global.is_static &&
hir_module.exprs[global.expr].kind == .Undefined &&
len(ir_module.globals[global_index].initializer) > 0 &&
ir_module.globals[global_index].initializer[0].op == .Poison
} else if name == "values" {
item, ok := types.node(&hir_module.types, global.type)
found_values = global.writable && !global.is_static && ok && item.kind == .Array && item.count == 2
@@ -9256,6 +9264,7 @@ main func() void {
testing.expect(t, found_counter)
testing.expect(t, found_ratio)
testing.expect(t, found_span)
testing.expect(t, found_unset)
testing.expect(t, found_values)
testing.expect(t, strings.contains(llvm_text, "internal global"))
testing.expect(t, !strings.contains(llvm_text, "internal constant i32 0"))
@@ -9267,7 +9276,6 @@ mutable_global_diagnostics_and_no_shadowing :: proc(t: ^testing.T) {
OtherID :: distinct i32
ID i32 = 0
counter = 0
bad i32 = undefined
runtime i32 = 1
immutable :: 1
foo func(foo i32) void {}
@@ -9304,7 +9312,6 @@ main func() void {
defer hir.destroy_module(&hir_module)
missing_type := false
undefined_global := false
not_comptime := false
immutable_write := false
global_type_shadow := false
@@ -9317,7 +9324,6 @@ main func() void {
value_label_shadow := false
for diagnostic in diagnostics.items {
missing_type = missing_type || strings.contains(diagnostic.message, "mutable global 'counter' requires a type annotation")
undefined_global = undefined_global || strings.contains(diagnostic.message, "'undefined' is only valid as a mutable local declaration initializer")
not_comptime = not_comptime || strings.contains(diagnostic.message, "global 'runtime' is not comptime-known")
immutable_write = immutable_write || strings.contains(diagnostic.message, "assignment target is not writable")
global_type_shadow = global_type_shadow || strings.contains(diagnostic.message, "global 'ID' shadows visible type")
@@ -9330,7 +9336,6 @@ main func() void {
value_label_shadow = value_label_shadow || strings.contains(diagnostic.message, "local 'value_label' shadows visible label")
}
testing.expect(t, missing_type)
testing.expect(t, undefined_global)
testing.expect(t, not_comptime)
testing.expect(t, immutable_write)
testing.expect(t, global_type_shadow)
@@ -11914,7 +11919,7 @@ main func() void {
for diagnostic in diagnostics.items {
immutable_count += 1 if strings.contains(diagnostic.message, "'undefined' requires a mutable local declaration") else 0
found_unresolved = found_unresolved || strings.contains(diagnostic.message, "could not infer a concrete type for local 'unresolved'")
found_assignment = found_assignment || strings.contains(diagnostic.message, "'undefined' is only valid as a mutable local declaration initializer")
found_assignment = found_assignment || strings.contains(diagnostic.message, "'undefined' is only valid as a mutable declaration initializer")
found_incompatible = found_incompatible || strings.contains(diagnostic.message, "cannot implicitly convert f64 to i8")
}