feat: persist notes window size and use monospaced text

2026-10-19 18:45:00 +02:00
parent fea0041302
commit afa27b941f
5 changed files with 82 additions and 13 deletions
@@ -256,7 +256,6 @@ func notesNativeClosePreservesUnsavedEditsAndRestoresBorderlessLauncher(_ blockS
    #expect(!close.isHidden && close.isEnabled)
    #expect(window.standardWindowButton(.miniaturizeButton)?.isHidden != false)
    #expect(window.standardWindowButton(.zoomButton)?.isHidden != false)
-    #expect(window.frame.size == NSSize(width: 570, height: 404))
    if blockSaving {
        try FileManager.default.moveItem(at: directory, to: backup)
        try Data("Blocked storage".utf8).write(to: directory)
@@ -284,6 +283,63 @@ func notesNativeClosePreservesUnsavedEditsAndRestoresBorderlessLauncher(_ blockS
    #expect(window.standardWindowButton(.zoomButton)?.isHidden != false)
 }

+@Test @MainActor
+func notesRememberResizedDimensionsWithoutResizingOtherCommandsAndKeepTextMonospaced() throws {
+    _ = NSApplication.shared
+    let suite = "NotesWindowSize.\(UUID().uuidString)"
+    let defaults = try #require(UserDefaults(suiteName: suite))
+    let directory = FileManager.default.temporaryDirectory.appendingPathComponent(suite)
+    defer {
+        defaults.removePersistentDomain(forName: suite)
+        try? FileManager.default.removeItem(at: directory)
+    }
+    func makeLauncher() -> LauncherWindowController {
+        LauncherWindowController(
+            history: LaunchHistory(defaults: defaults, now: { Date(timeIntervalSinceReferenceDate: 12_000) }),
+            defaults: defaults, notesDirectory: directory)
+    }
+    let launcher = makeLauncher()
+    let window = try #require(launcher.window)
+    defer { launcher.dismiss(restoringFocus: false) }
+    let launcherSize = window.frame.size
+    launcher.present(command: .notes)
+    #expect(window.styleMask.contains(.resizable))
+    func descendants(_ view: NSView) -> [NSView] { [view] + view.subviews.flatMap(descendants) }
+    let content = try #require(window.contentView)
+    let editor = try #require(descendants(content).compactMap { $0 as? NotesTextView }.first)
+    editor.insertText("Plain\n# Heading\n**bold** and *italic* and `code`", replacementRange: editor.selectedRange())
+    let storage = try #require(editor.textStorage)
+    storage.enumerateAttribute(.font, in: NSRange(location: 0, length: storage.length)) { value, _, _ in
+        #expect((value as? NSFont)?.isFixedPitch == true)
+    }
+    #expect((editor.typingAttributes[.font] as? NSFont)?.isFixedPitch == true)
+    let expanded = NSSize(width: 840, height: 620)
+    var frame = window.frame
+    frame.size = expanded
+    window.setFrame(frame, display: true)
+    window.contentView?.layoutSubtreeIfNeeded()
+    #expect(editor.enclosingScrollView?.frame.width == expanded.width)
+    #expect(editor.visibleRect.height > 400)
+    launcher.present(command: .emoji)
+    #expect(window.frame.size == launcherSize)
+    #expect(!window.styleMask.contains(.resizable))
+    launcher.present(command: .notes)
+    #expect(window.frame.size == expanded)
+    let compact = NSSize(width: 620, height: 330)
+    frame = window.frame
+    frame.size = compact
+    window.setFrame(frame, display: true)
+    launcher.dismiss(restoringFocus: false)
+
+    // A fresh controller reads persisted dimensions, not an in-memory frame.
+    let reopened = makeLauncher()
+    defer { reopened.dismiss(restoringFocus: false) }
+    reopened.present(command: .notes)
+    #expect(reopened.window?.frame.size == compact)
+    reopened.present(command: .translate)
+    #expect(reopened.window?.frame.size == launcherSize)
+}
+
@Test @MainActor
 func markdownListReturnContinuesExitsAndUndoesAtArbitraryDepths() throws {
    _ = NSApplication.shared