feat: translate with situational context in OpenAI
This commit is contained in:
@@ -5,13 +5,13 @@ import Testing
|
||||
|
||||
@MainActor
|
||||
private final class TranslationRequests {
|
||||
var inputs: [(text: String, source: String, target: String, key: String?)] = []
|
||||
var inputs: [(text: String, source: String, target: String, key: String?, context: String)] = []
|
||||
var pending: [CheckedContinuation<String, any Error>] = []
|
||||
var returned = 0
|
||||
|
||||
// Deliberately ignore cancellation: the controller must reject late completions itself.
|
||||
func translate(_ text: String, source: String, target: String, key: String? = nil) async throws -> String {
|
||||
inputs.append((text, source, target, key))
|
||||
func translate(_ text: String, source: String, target: String, key: String? = nil, context: String = "") async throws -> String {
|
||||
inputs.append((text, source, target, key, context))
|
||||
defer { returned += 1 }
|
||||
return try await withCheckedThrowingContinuation { pending.append($0) }
|
||||
}
|
||||
@@ -172,7 +172,7 @@ func translationExecutionIsExplicitAndMyMemoryNeverTouchesCredentials() async th
|
||||
let requests = TranslationRequests()
|
||||
let tool = TranslationController(defaults: defaults, credentials: keys.store,
|
||||
myMemory: { try await requests.translate($0, source: $1, target: $2) },
|
||||
openAI: { try await requests.translate($0, source: $1, target: $2, key: $3) })
|
||||
openAI: { try await requests.translate($0, source: $1, target: $2, key: $3, context: $4) })
|
||||
tool.input = { "Hello" }
|
||||
let views = descendants(tool.view)
|
||||
let output = try #require(views.compactMap { $0 as? NSTextView }.first)
|
||||
@@ -200,7 +200,7 @@ func translationExecutionRejectsOldCompletionsWithoutClearingNewRequests() async
|
||||
let requests = TranslationRequests()
|
||||
let tool = TranslationController(defaults: defaults, credentials: keys.store,
|
||||
myMemory: { try await requests.translate($0, source: $1, target: $2) },
|
||||
openAI: { try await requests.translate($0, source: $1, target: $2, key: $3) })
|
||||
openAI: { try await requests.translate($0, source: $1, target: $2, key: $3, context: $4) })
|
||||
var input = "first"
|
||||
tool.input = { input }
|
||||
let views = descendants(tool.view)
|
||||
@@ -253,7 +253,7 @@ func translationExecutionRecoversFromCredentialAndRequestFailures() async throws
|
||||
let requests = TranslationRequests()
|
||||
let tool = TranslationController(defaults: defaults, credentials: keys.store,
|
||||
myMemory: { try await requests.translate($0, source: $1, target: $2) },
|
||||
openAI: { try await requests.translate($0, source: $1, target: $2, key: $3) })
|
||||
openAI: { try await requests.translate($0, source: $1, target: $2, key: $3, context: $4) })
|
||||
tool.input = { "Hello" }
|
||||
let views = descendants(tool.view)
|
||||
let settings = TranslationSettingsController(credentials: keys.store)
|
||||
@@ -317,4 +317,122 @@ func translationExecutionRecoversFromCredentialAndRequestFailures() async throws
|
||||
try await waitForTranslation { output.string == "成功" }
|
||||
#expect(status.textColor != .systemRed)
|
||||
}
|
||||
|
||||
@Test @MainActor
|
||||
func openAICollectsContextBeforeSendingAndRejectsObsoleteContextResults() async throws {
|
||||
_ = NSApplication.shared
|
||||
let suite = "TranslateContext.\(UUID().uuidString)"
|
||||
let defaults = UserDefaults(suiteName: suite)!
|
||||
defaults.set("openai", forKey: "translationProvider")
|
||||
let pasteboard = NSPasteboard.withUniqueName()
|
||||
defer {
|
||||
defaults.removePersistentDomain(forName: suite)
|
||||
pasteboard.releaseGlobally()
|
||||
}
|
||||
let keys = TranslationKeys()
|
||||
keys.value = "saved-key"
|
||||
let requests = TranslationRequests()
|
||||
let tool = TranslationController(defaults: defaults, credentials: keys.store,
|
||||
openAI: { try await requests.translate($0, source: $1, target: $2, key: $3, context: $4) },
|
||||
pasteboard: pasteboard)
|
||||
var input = "お疲れ様です"
|
||||
tool.input = { input }
|
||||
tool.replaceInput = { input = $0 }
|
||||
var dismissed = false
|
||||
tool.dismiss = { dismissed = true }
|
||||
let output = try #require(descendants(tool.view).compactMap { $0 as? NSTextView }.first)
|
||||
let button = try #require(descendants(tool.view).compactMap { $0 as? NSButton }
|
||||
.first { $0.action == NSSelectorFromString("performPrimaryAction") })
|
||||
tool.setLanguages(source: "ja", target: "en")
|
||||
tool.performPrimaryAction()
|
||||
#expect(input.isEmpty)
|
||||
#expect(requests.inputs.isEmpty)
|
||||
#expect(keys.accesses == 0)
|
||||
#expect(descendants(tool.view).compactMap { $0 as? NSTextField }.contains {
|
||||
!$0.isHidden && $0.stringValue.contains("お疲れ様です")
|
||||
})
|
||||
input = "A coworker greeting me at the start of a shift"
|
||||
tool.inputChanged()
|
||||
#expect(requests.inputs.isEmpty)
|
||||
tool.performPrimaryAction()
|
||||
try await waitForTranslation { requests.pending.count == 1 }
|
||||
#expect(requests.inputs[0].text == "お疲れ様です")
|
||||
#expect(requests.inputs[0].context == input)
|
||||
#expect(requests.inputs[0].source == "ja")
|
||||
#expect(requests.inputs[0].target == "en")
|
||||
input = "A coworker thanking me after a long shift"
|
||||
tool.inputChanged()
|
||||
tool.performPrimaryAction()
|
||||
try await waitForTranslation { requests.pending.count == 2 }
|
||||
#expect(requests.inputs[1].text == "お疲れ様です")
|
||||
#expect(requests.inputs[1].context == input)
|
||||
requests.pending[0].resume(returning: "Hello")
|
||||
try await waitForTranslation { requests.returned == 1 }
|
||||
#expect(output.string.isEmpty)
|
||||
#expect(!button.isEnabled)
|
||||
requests.pending[1].resume(returning: "Thanks for your hard work")
|
||||
try await waitForTranslation { button.isEnabled }
|
||||
tool.performPrimaryAction()
|
||||
#expect(pasteboard.string(forType: .string) == "Thanks for your hard work")
|
||||
#expect(dismissed)
|
||||
tool.goBack()
|
||||
#expect(input == "お疲れ様です")
|
||||
#expect(output.string.isEmpty)
|
||||
}
|
||||
|
||||
@Test @MainActor
|
||||
func blankContextTranslatesWithoutSwappingAndProviderChangesRestoreOriginalText() async throws {
|
||||
_ = NSApplication.shared
|
||||
let suite = "TranslateOptionalContext.\(UUID().uuidString)"
|
||||
let defaults = UserDefaults(suiteName: suite)!
|
||||
defaults.set("openai", forKey: "translationProvider")
|
||||
let pasteboard = NSPasteboard.withUniqueName()
|
||||
defer {
|
||||
defaults.removePersistentDomain(forName: suite)
|
||||
pasteboard.releaseGlobally()
|
||||
}
|
||||
let keys = TranslationKeys()
|
||||
keys.value = "saved-key"
|
||||
let requests = TranslationRequests()
|
||||
let tool = TranslationController(defaults: defaults, credentials: keys.store,
|
||||
myMemory: { try await requests.translate($0, source: $1, target: $2) },
|
||||
openAI: { try await requests.translate($0, source: $1, target: $2, key: $3, context: $4) },
|
||||
pasteboard: pasteboard)
|
||||
var input = "Hello"
|
||||
tool.input = { input }
|
||||
tool.replaceInput = { input = $0 }
|
||||
var dismissed = false
|
||||
tool.dismiss = { dismissed = true }
|
||||
let output = try #require(descendants(tool.view).compactMap { $0 as? NSTextView }.first)
|
||||
let button = try #require(descendants(tool.view).compactMap { $0 as? NSButton }
|
||||
.first { $0.action == NSSelectorFromString("performPrimaryAction") })
|
||||
tool.performPrimaryAction()
|
||||
tool.performPrimaryAction()
|
||||
try await waitForTranslation { requests.pending.count == 1 }
|
||||
#expect(requests.inputs[0].text == "Hello")
|
||||
#expect(requests.inputs[0].context.isEmpty)
|
||||
#expect(tool.sourceLanguage == "en")
|
||||
requests.pending[0].resume(returning: "こんにちは")
|
||||
try await waitForTranslation { button.isEnabled }
|
||||
tool.performPrimaryAction()
|
||||
#expect(pasteboard.string(forType: .string) == "こんにちは")
|
||||
#expect(dismissed)
|
||||
input = "A friendly greeting"
|
||||
tool.inputChanged()
|
||||
tool.performPrimaryAction()
|
||||
try await waitForTranslation { requests.pending.count == 2 }
|
||||
tool.selectProvider(openAI: false)
|
||||
#expect(input == "Hello")
|
||||
#expect(output.string.isEmpty)
|
||||
tool.performPrimaryAction()
|
||||
try await waitForTranslation { requests.pending.count == 3 }
|
||||
#expect(requests.inputs[2].text == "Hello")
|
||||
#expect(requests.inputs[2].key == nil)
|
||||
#expect(requests.inputs[2].context.isEmpty)
|
||||
requests.pending[1].resume(returning: "obsolete")
|
||||
try await waitForTranslation { requests.returned == 2 }
|
||||
#expect(output.string.isEmpty)
|
||||
requests.pending[2].resume(returning: "やあ")
|
||||
try await waitForTranslation { output.string == "やあ" }
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user