feat: add persistent Markdown notes

2026-10-17 00:53:28 +02:00
parent 0f49209d95
commit e36a8bbc6b
13 changed files with 584 additions and 23 deletions
@@ -0,0 +1,81 @@
+import AppKit
+import ConjureKit
+import Testing
+@testable import Conjure
+
+@Test @MainActor
+func notesSwitchWithoutLeakingEditsUndoOrAttachmentsAndRestoreSelection() throws {
+    _ = NSApplication.shared
+    let directory = FileManager.default.temporaryDirectory.appendingPathComponent(UUID().uuidString)
+    let suite = "NotesEditing.\(UUID().uuidString)"
+    let defaults = try #require(UserDefaults(suiteName: suite))
+    defer {
+        try? FileManager.default.removeItem(at: directory)
+        defaults.removePersistentDomain(forName: suite)
+    }
+    let controller = NotesController(defaults: defaults, directory: directory)
+    let window = NSWindow(contentRect: NSRect(x: 0, y: 0, width: 750, height: 390), styleMask: [.borderless], backing: .buffered, defer: false)
+    window.contentViewController = controller
+    defer { window.orderOut(nil) }
+    func descendants(_ view: NSView) -> [NSView] { [view] + view.subviews.flatMap(descendants) }
+    let views = descendants(controller.view)
+    let editor = try #require(views.compactMap { $0 as? NotesTextView }.first)
+    let picker = try #require(views.compactMap { $0 as? NSPopUpButton }.first)
+    let create = try #require(views.compactMap { $0 as? NSButton }.first { $0.title == "New Note" })
+    let firstID = try #require(picker.selectedItem?.representedObject as? UUID)
+    // Empty notes have duplicate titles; both must remain individually selectable.
+    create.performClick(nil)
+    #expect(picker.numberOfItems == 2)
+    let secondID = try #require(picker.selectedItem?.representedObject as? UUID)
+    #expect(secondID != firstID)
+    editor.insertText("# Second 🦊\n**bold** and `code`", replacementRange: editor.selectedRange())
+    #expect((editor.textStorage?.attribute(.font, at: 0, effectiveRange: nil) as? NSFont)?.pointSize == 17)
+    let codeRange = (editor.string as NSString).range(of: "`code`")
+    let codeFont = try #require(editor.textStorage?.attribute(.font, at: codeRange.location, effectiveRange: nil) as? NSFont)
+    #expect(codeFont.isFixedPitch)
+    let firstIndex = try #require(picker.itemArray.firstIndex { $0.representedObject as? UUID == firstID })
+    picker.selectItem(at: firstIndex)
+    _ = NSApp.sendAction(try #require(picker.action), to: picker.target, from: picker)
+    #expect(editor.string.isEmpty)
+    #expect(editor.undoManager?.canUndo != true)
+    editor.insertText("First note", replacementRange: editor.selectedRange())
+    let bitmap = try #require(NSBitmapImageRep(bitmapDataPlanes: nil, pixelsWide: 1, pixelsHigh: 1, bitsPerSample: 8, samplesPerPixel: 4, hasAlpha: true, isPlanar: false, colorSpaceName: .deviceRGB, bytesPerRow: 0, bitsPerPixel: 0))
+    bitmap.setColor(.red, atX: 0, y: 0)
+    let imageURL = directory.appendingPathComponent("image.png")
+    try #require(bitmap.representation(using: .png, properties: [:])).write(to: imageURL)
+    try editor.insertImage(at: imageURL)
+    #expect(controller.save())
+    let restored = try NotesStore(directory: directory)
+    let first = try #require(restored.notes.first { $0.id == firstID })
+    #expect(first.contents.string == "First note\u{fffc}")
+    #expect(first.contents.attribute(.attachment, at: 10, effectiveRange: nil) is NSTextAttachment)
+    #expect(restored.notes.first { $0.id == secondID }?.contents.string == "# Second 🦊\n**bold** and `code`")
+    let reopened = NotesController(defaults: defaults, directory: directory)
+    let reopenedViews = descendants(reopened.view)
+    let reopenedEditor = try #require(reopenedViews.compactMap { $0 as? NotesTextView }.first)
+    #expect(reopenedEditor.string == first.contents.string)
+    // Removing Markdown must also remove its previous visual style without changing the source.
+    reopenedEditor.insertText("Plain text", replacementRange: NSRange(location: 0, length: reopenedEditor.string.utf16.count))
+    #expect((reopenedEditor.textStorage?.attribute(.font, at: 0, effectiveRange: nil) as? NSFont)?.pointSize == 14)
+    #expect(reopenedEditor.string == "Plain text")
+    let backup = directory.appendingPathExtension("backup")
+    defer { try? FileManager.default.removeItem(at: backup) }
+    try FileManager.default.moveItem(at: directory, to: backup)
+    try Data("Blocked storage".utf8).write(to: directory)
+    reopenedEditor.insertText("Unsaved", replacementRange: NSRange(location: 0, length: reopenedEditor.string.utf16.count))
+    var closed = false
+    reopened.closed = { closed = true }
+    reopened.goBack()
+    #expect(!closed)
+    #expect(!reopened.save())
+    let reopenedPicker = try #require(reopenedViews.compactMap { $0 as? NSPopUpButton }.first)
+    reopenedPicker.selectItem(at: try #require(reopenedPicker.itemArray.firstIndex { $0.representedObject as? UUID == secondID }))
+    _ = NSApp.sendAction(try #require(reopenedPicker.action), to: reopenedPicker.target, from: reopenedPicker)
+    #expect(reopenedEditor.string == "Unsaved")
+    #expect(reopenedPicker.selectedItem?.representedObject as? UUID == firstID)
+    try FileManager.default.removeItem(at: directory)
+    try FileManager.default.moveItem(at: backup, to: directory)
+    #expect(reopened.save())
+    reopened.goBack()
+    #expect(closed)
+}