feat: use searchable themed translation language picker

2026-10-18 18:00:04 +02:00
parent cd47828ddb
commit fa3591adf8
6 changed files with 370 additions and 105 deletions
@@ -0,0 +1,104 @@
+import AppKit
+import Testing
+@testable import Conjure
+
+@MainActor
+private func descendants(_ view: NSView) -> [NSView] { [view] + view.subviews.flatMap(descendants) }
+
+@Suite(.serialized)
+struct LanguagePickerTests {
+    @Test @MainActor
+    func translationActionsFuzzySelectBothLanguagesAndKeepCancellationLocal() throws {
+        _ = NSApplication.shared
+        let suite = "LanguagePicker.\(UUID().uuidString)"
+        let defaults = UserDefaults(suiteName: suite)!
+        defer { defaults.removePersistentDomain(forName: suite) }
+        let tool = TranslationController(defaults: defaults,
+            myMemory: { _, _, _ in Issue.record("Selecting a language must not translate"); return "unexpected" })
+        tool.input = { "Text stays unchanged" }
+        let window = NSWindow(contentRect: NSRect(x: 0, y: 0, width: 750, height: 474),
+            styleMask: .borderless, backing: .buffered, defer: false)
+        window.isReleasedWhenClosed = false
+        window.contentView = tool.view
+        defer { tool.close(); window.orderOut(nil) }
+        let host = try #require(window.contentView)
+        var closed = false
+        tool.closed = { closed = true }
+        var focused = false
+        tool.focusSearch = { focused = true }
+
+        func search(_ label: String) throws -> NSSearchField {
+            try #require(descendants(host).compactMap { $0 as? NSSearchField }.first { $0.accessibilityLabel() == label })
+        }
+        func filter(_ field: NSSearchField, _ query: String) {
+            field.stringValue = query
+            field.delegate?.controlTextDidChange?(Notification(name: NSControl.textDidChangeNotification, object: field))
+            host.layoutSubtreeIfNeeded()
+        }
+        func openLanguages(source: Bool) throws -> NSSearchField {
+            tool.showActions()
+            filter(try search("Search translation actions"), source ? "source" : "target")
+            #expect(tool.handle(#selector(NSResponder.insertNewline(_:))))
+            return try search(source ? "Search source languages" : "Search target languages")
+        }
+
+        let source = try openLanguages(source: true)
+        filter(source, "jpns")
+        #expect(tool.handle(#selector(NSResponder.insertNewline(_:))))
+        #expect(tool.sourceLanguage == "ja")
+        #expect(tool.targetLanguage == "ja")
+        #expect(focused)
+        #expect(!closed)
+
+        let target = try openLanguages(source: false)
+        filter(target, "grmn")
+        let german = try #require(descendants(host).compactMap { $0 as? NSButton }.first { $0.title == "German" })
+        german.performClick(nil)
+        #expect(tool.targetLanguage == "de")
+        #expect(defaults.string(forKey: "translationSourceLanguage") == "ja")
+        #expect(defaults.string(forKey: "translationTargetLanguage") == "de")
+
+        let cancelled = try openLanguages(source: false)
+        filter(cancelled, "zzzzzzzz")
+        #expect(tool.handle(#selector(NSResponder.insertNewline(_:))))
+        #expect(tool.targetLanguage == "de")
+        #expect(cancelled.window === window)
+        #expect(tool.handle(#selector(NSResponder.cancelOperation(_:))))
+        #expect(!closed)
+        #expect(tool.input?() == "Text stays unchanged")
+        let reopened = TranslationController(defaults: defaults)
+        #expect(reopened.sourceLanguage == "ja")
+        #expect(reopened.targetLanguage == "de")
+    }
+
+    @Test @MainActor
+    func languageListScrollsToCurrentSelectionAndNavigatesBeyondVisibleRows() throws {
+        _ = NSApplication.shared
+        let window = NSWindow(contentRect: NSRect(x: 0, y: 0, width: 750, height: 474),
+            styleMask: .borderless, backing: .buffered, defer: false)
+        window.isReleasedWhenClosed = false
+        let host = try #require(window.contentView)
+        let pill = NSView(frame: NSRect(x: 500, y: 8, width: 230, height: 36))
+        let anchor = NSButton(frame: pill.bounds)
+        pill.addSubview(anchor)
+        host.addSubview(pill)
+        let popup = ApplicationActionsController()
+        defer { popup.close(animated: false); window.orderOut(nil) }
+        let choices = (0..<20).map { (code: "\($0)", name: String(format: "Language %02d", $0)) }
+        var selected: String?
+        popup.selectLanguage = { selected = $0 }
+        popup.showLanguages(choices, selected: "15", source: true, relativeTo: anchor)
+        host.layoutSubtreeIfNeeded()
+        let table = try #require(descendants(popup.view).compactMap { $0 as? NSTableView }.first)
+        #expect(table.selectedRow == 15)
+        #expect(NSLocationInRange(table.selectedRow, table.rows(in: table.visibleRect)))
+        #expect(table.visibleRect.height < table.bounds.height)
+        popup.moveSelection(by: -10)
+        #expect(table.selectedRow == 5)
+        #expect(NSLocationInRange(table.selectedRow, table.rows(in: table.visibleRect)))
+        #expect(popup.handle(#selector(NSResponder.insertNewline(_:))))
+        #expect(selected == "5")
+        popup.close(animated: false)
+        #expect(!pill.isAccessibilityHidden())
+    }
+}