hl-valdemar/terebi
1
0
Fork 0
Code Issues Pull Requests Actions Packages Releases Wiki Activity

fix: restore balanced playback controls alignment

Browse Source
This commit is contained in:
Valdemar Høgsvig Lorenzen
2026-10-22 12:03:04 +02:00
parent 4bf738d8d2
commit 80c5f36479
2 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Sources/App/TerebiApp.swift
+1 -1
View File
@@ -2656,7 +2656,7 @@ private struct PlayerContent: View {
enabled: model.canSeek, bufferedRange: buffered, intervals: intervals, onEditingChanged: { editing in enabled: model.canSeek, bufferedRange: buffered, intervals: intervals, onEditingChanged: { editing in
if editing { model.beginSeeking() } else { model.finishSeeking() } if editing { model.beginSeeking() } else { model.finishSeeking() }
}) })
.frame(height: intervals.isEmpty ? 14 : 32) .frame(height: 14)
.accessibilityLabel("Playback Position") .accessibilityLabel("Playback Position")
.accessibilityValue(time(model.seekPosition) + (timelineStatus.isEmpty ? "" : ", " + timelineStatus)) .accessibilityValue(time(model.seekPosition) + (timelineStatus.isEmpty ? "" : ", " + timelineStatus))
.help(timelineStatus.isEmpty ? "Playback Position" : timelineStatus) .help(timelineStatus.isEmpty ? "Playback Position" : timelineStatus)
docs/miruro-playback-handoff.md
+2
View File
@@ -167,6 +167,8 @@ URL smoke expects a fixture episode with available title, bands and default subt
Metadata implementation verification (2026-10-22): protocol/security/bounds checks, lifecycle replacement/A-B-A stale results/duration changes, stream resolver and CLI checks passed. The live placeholder resolved the descriptive title “The Apothecary Diaries Season 3 — Episode 1: Locusts,” opening 63.313–153.237 seconds and ending 1335.252–1425.384 seconds; native video/audio advanced, measured-duration bands appeared in model state, and default VTT plus forward/backward acknowledged cue seeks passed. FFmpeg emitted redacted diagnostics during this successful run; no visual synchronization or visible-band sign-off is claimed. Metadata implementation verification (2026-10-22): protocol/security/bounds checks, lifecycle replacement/A-B-A stale results/duration changes, stream resolver and CLI checks passed. The live placeholder resolved the descriptive title “The Apothecary Diaries Season 3 — Episode 1: Locusts,” opening 63.313–153.237 seconds and ending 1335.252–1425.384 seconds; native video/audio advanced, measured-duration bands appeared in model state, and default VTT plus forward/backward acknowledged cue seeks passed. FFmpeg emitted redacted diagnostics during this successful run; no visual synchronization or visible-band sign-off is claimed.
Controls alignment correction: removed the obsolete label-height reservation after switching to gapped segments. A native offscreen SwiftUI/AppKit layout smoke reproduced a 9-point top-row shift when intervals appeared; after restoring the standard 14-point slider frame, volume and timeline geometry match exactly with and without intervals. Production build passed; visible confirmation remains a human check.
## Remaining limits ## Remaining limits
- Confirm title readability and gapped slider segments in normal/compact controls, buffer/playhead visibility and subtitle alignment in the visible app using Tubular's real launch path. Offscreen native rasterization at compact/normal widths confirmed all four interval-boundary gaps remain clear even with full buffer coverage. - Confirm title readability and gapped slider segments in normal/compact controls, buffer/playhead visibility and subtitle alignment in the visible app using Tubular's real launch path. Offscreen native rasterization at compact/normal widths confirmed all four interval-boundary gaps remain clear even with full buffer coverage.