hl-valdemar/vamp
1
0
Fork 0
Code Issues Pull Requests Actions Packages Releases Wiki Activity

fix: save review comments only on explicit write

Browse Source
This commit is contained in:
Valdemar Høgsvig Lorenzen
2026-10-17 01:36:45 +02:00
parent e9a757adc5
commit 2cb3736b92
7 changed files with 246 additions and 40 deletions
Download Patch File Download Diff File Expand all files Collapse all files
TODO.md
+2 -1
View File
@@ -2,8 +2,9 @@
- honeylang treesitter project located at `/Users/valdemar/Developer/Personal/Languages/tree-sitter-honey`.
- [x] bug: `x` cut action does not copy the hovered character if not in selection mode, though should always copy.
- [x] make diff comments word wrap / line wrap by default
- [ ] currently, a review comment seems to be attached even if the user doesn't "save" or write the comment buffer (e.g. using `:w`). just closing it with escape still seems to write it to the db.
- [x] currently, a review comment seems to be attached even if the user doesn't "save" or write the comment buffer (e.g. using `:w`). just closing it with escape still seems to write it to the db.
- comments should be discardable
- [ ] cycle previous commands and search text in command and search input when pressing arrows up/down or ctrl+j/k.
- [ ] diff view: GitHub code review integration after the local review UX is usable.
- publish local reviews explicitly: general PR comments, inline line/range comments, review summaries, approval, and requests for changes.
- preserve explicit PR identity and reviewed commit IDs; validate anchors against GitHub's PR diff and recheck the PR head before submission.