hl-valdemar/vamp
1
0
Fork 0
Code Issues Pull Requests Actions Packages Releases Wiki Activity

fix: overlay clipped scope labels without reflow

Browse Source
This commit is contained in:
Valdemar Lorenzen
2026-10-16 11:02:44 +02:00
parent e37fa509c9
commit 682427324d
3 changed files with 215 additions and 62 deletions
Download Patch File Download Diff File Expand all files Collapse all files
TODO.md
+2 -2
View File
@@ -13,8 +13,8 @@
- [x] action to scroll viewport without having to move the cursor (like vim's `ctrl+e|u`).
- [x] scroll viewport action (`ctrl+u|d`) scroll distance should be configurable.
- [x] file picker file search should also be fuzzy (we should be able to use the same fuzzy implemented for diff view search, i believe)
- [ ] diff view: labels are currently attached also when scrolling the view port horizontally (such that e.g. a function name is not fully visible in the viewport), which is good, but it currently attaches at that line, thus pushing down the function by one line, which causes a one-line jump when scrolling horizontally.
- we should in this case attach the label above the function instead of on the same line that it's defined such that it's not pushed down.
- [x] diff view: labels are currently attached also when scrolling the view port horizontally (such that e.g. a function name is not fully visible in the viewport), which is good, but it currently attaches at that line, thus pushing down the function by one line, which causes a one-line jump when scrolling horizontally.
- horizontal labels overlay the row above the declaration, or the pane's top border, without shifting source rows.
- [ ] diff view: github integration (code review) - add comments on a pr, add review comments at specific lines of files, request changes, approve pr, etc.
- [ ] diff view: local review comments (same features as for github reviews) that allows review of local changes to deliver specific reviews to ai agents used for coding.
- design question: would this require a server that the agent can interact with, or would local review files be fine? don't want to use server client stuff, if it would be easier and better to just use local files.