fix: key review checkmarks by file snapshots instead of revision pairs

This commit is contained in:
Valdemar Lorenzen
2026-10-20 11:09:48 +02:00
parent ea04e30072
commit 8f8d96ead9
9 changed files with 164 additions and 12 deletions
+9
View File
@@ -1984,6 +1984,7 @@ fn syntax_diff_file(path: &str, before: &str, after: &str) -> ChangedFile {
let before: Vec<String> = before.split('\n').map(str::to_owned).collect();
let after: Vec<String> = after.split('\n').map(str::to_owned).collect();
ChangedFile {
review_revisions: None,
loaded: true,
before_eof: false,
after_eof: false,
@@ -2605,6 +2606,7 @@ fn diff_comparison(files: Vec<ChangedFile>) -> DiffState {
fn deletion_file() -> ChangedFile {
ChangedFile {
review_revisions: None,
loaded: true,
before_eof: false,
after_eof: false,
@@ -3555,6 +3557,7 @@ fn diff_excerpts_render_original_lines_and_expand_without_losing_changes() {
after[30] = "let first_change = 900;".into();
after[60] = "let second_change = 901;".into();
let mut diff = diff_comparison(vec![ChangedFile {
review_revisions: None,
loaded: true,
before_eof: false,
after_eof: false,
@@ -3694,6 +3697,7 @@ fn diff_row_tint_covers_blank_lines_and_wrapped_gutters() {
#[test]
fn diff_added_rows_hatch_missing_before_but_tint_real_empty_after_lines() {
let mut diff = diff_comparison(vec![ChangedFile {
review_revisions: None,
loaded: true,
before_eof: false,
after_eof: false,
@@ -3751,6 +3755,7 @@ fn diff_added_rows_hatch_missing_before_but_tint_real_empty_after_lines() {
#[test]
fn diff_changed_backgrounds_preserve_syntax_and_clipped_source_cells() {
let mut diff = diff_comparison(vec![ChangedFile {
review_revisions: None,
loaded: true,
before_eof: false,
after_eof: false,
@@ -3880,6 +3885,7 @@ fn diff_changed_backgrounds_preserve_syntax_and_clipped_source_cells() {
#[test]
fn diff_view_changes_files_focus_and_keeps_horizontal_offsets_independent() {
let added = ChangedFile {
review_revisions: None,
loaded: true,
before_eof: false,
after_eof: false,
@@ -4641,6 +4647,7 @@ fn large_generated_additions_render_first_scroll_and_final_rows_without_reparsin
.collect::<Vec<_>>();
let hunks = crate::diff::line_hunks(&[], false, &after, true);
let mut diff = diff_comparison(vec![ChangedFile {
review_revisions: None,
path: "parser.c".into(),
old_path: None,
status: FileStatus::Added,
@@ -4690,6 +4697,7 @@ fn diff_notices_empty_comparisons_and_tiny_layouts_remain_renderable() {
assert!(screen_text(&terminal).contains("No changed files"));
assert!(screen_text(&terminal).contains("Explorer · Tree"));
let binary = diff_comparison(vec![ChangedFile {
review_revisions: None,
loaded: true,
before_eof: false,
after_eof: false,
@@ -4704,6 +4712,7 @@ fn diff_notices_empty_comparisons_and_tiny_layouts_remain_renderable() {
render_diff(&mut terminal, &binary, &mut panels);
assert!(screen_text(&terminal).contains("Binary file"));
let blank = diff_comparison(vec![ChangedFile {
review_revisions: None,
loaded: true,
before_eof: false,
after_eof: false,