hl-valdemar/vamp
1
0
Fork 0
Code Issues Pull Requests Actions Packages Releases Wiki Activity

refactor: name configurable viewport scroll steps accurately

Browse Source
This commit is contained in:
Valdemar Lorenzen
2026-10-16 10:31:36 +02:00
parent 284ddd3713
commit d1048df345
12 changed files with 80 additions and 54 deletions
Download Patch File Download Diff File Expand all files Collapse all files
TODO.md
+1
View File
@@ -12,6 +12,7 @@
- [x] diff view: automatically detect changes and update the view when relevant bookmarks move change ids (regards bookmark-based diff view; i.e., user selected at least one bookmark in the before/after picker)
- [x] action to scroll viewport without having to move the cursor (like vim's `ctrl+e|u`).
- [x] scroll viewport action (`ctrl+u|d`) scroll distance should be configurable.
- [ ] file picker file search should also be fuzzy (we should be able to use the same fuzzy implemented for diff view search, i believe)
- [ ] diff view: labels are currently attached also when scrolling the view port horizontally (such that e.g. a function name is not fully visible in the viewport), which is good, but it currently attaches at that line, thus pushing down the function by one line, which causes a one-line jump when scrolling horizontally.
- we should in this case attach the label above the function instead of on the same line that it's defined such that it's not pushed down.
- [ ] diff view: github integration (code review) - add comments on a pr, add review comments at specific lines of files, request changes, approve pr, etc.