feat: add persistent pull request sort and filter menus

tests/unit/ruby.rs

@@ -2356,3 +2356,80 @@ fn ruby_rejects_invalid_document_context_and_sync_async_dsl_usage() {
         plugin.host.child.is_none() && plugin.host.reader.is_none() && plugin.host.writer.is_none()
     );
 }
+
+#[test]
+fn pull_request_preferences_distinguish_unset_nil_and_explicit_sections() {
+    use crate::pull_requests::{Direction, ReviewFilter, SortField};
+    let fixture = Fixture::new();
+    for assignment in [
+        "",
+        "config.pull_request_sort = nil; config.pull_request_filters = nil",
+    ] {
+        let path = fixture.file(
+            "config.rb",
+            &format!("Vamp.configure {{ |config| {assignment} }}"),
+        );
+        let config = load_config(&path).unwrap();
+        assert!(config.pull_request_sort.is_none());
+        assert!(config.pull_request_filters.is_none());
+    }
+    let path = fixture.file(
+        "config.rb",
+        r#"
+        Vamp.configure do |config|
+          config.pull_request_sort = {
+            updated_at: {precedence: 1, direction: :desc},
+            created_at: {direction: :asc}
+          }
+          config.pull_request_filters = [:requested, :approved]
+        end
+    "#,
+    );
+    let config = load_config(&path).unwrap();
+    let sort = config.pull_request_sort.unwrap();
+    assert_eq!(sort[&SortField::UpdatedAt].precedence, Some(1));
+    assert_eq!(sort[&SortField::UpdatedAt].direction, Direction::Desc);
+    assert_eq!(sort[&SortField::CreatedAt].precedence, None);
+    assert_eq!(sort[&SortField::CreatedAt].direction, Direction::Asc);
+    assert_eq!(
+        config.pull_request_filters.unwrap(),
+        [ReviewFilter::Requested, ReviewFilter::Approved]
+    );
+    let path = fixture.file("config.rb", "Vamp.configure { |config| config.pull_request_sort = {}; config.pull_request_filters = [] }");
+    let config = load_config(&path).unwrap();
+    assert!(config.pull_request_sort.unwrap().is_empty());
+    assert!(config.pull_request_filters.unwrap().is_empty());
+}
+
+#[test]
+fn pull_request_preferences_reject_unknown_values_and_invalid_ranks() {
+    let fixture = Fixture::new();
+    for (field, value) in [
+        ("sort", "[]"),
+        ("sort", "{unknown: {}}"),
+        ("sort", "{updated_at: []}"),
+        ("sort", "{updated_at: {unknown: 1}}"),
+        ("sort", "{updated_at: {direction: :up}}"),
+        ("sort", "{updated_at: {direction: nil}}"),
+        ("sort", "{updated_at: {precedence: 0}}"),
+        ("sort", "{updated_at: {precedence: 5}}"),
+        ("sort", "{updated_at: {precedence: 1.0}}"),
+        (
+            "sort",
+            "{updated_at: {precedence: 1}, created_at: {precedence: 1}}",
+        ),
+        ("filters", "{}"),
+        ("filters", "[:unknown]"),
+        ("filters", "[:requested, :requested]"),
+    ] {
+        let path = fixture.file(
+            "config.rb",
+            &format!("Vamp.configure {{ |config| config.pull_request_{field} = {value} }}"),
+        );
+        let error = load_config(&path).unwrap_err();
+        assert!(
+            error.contains(&format!("pull_request_{field}")),
+            "{value}: {error}"
+        );
+    }
+}